feat(server): transport sandbox lifecycle hooks - #1589
Merged
Pangjiping merged 7 commits intoAug 24, 2026
Merged
Conversation
jianpingpei
requested review from
Generalwin,
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
August 20, 2026 10:20
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0ba38d997
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Pangjiping
reviewed
Aug 24, 2026
jianpingpei
requested review from
Spground,
fengcone and
kevinlynx
as code owners
August 24, 2026 04:07
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateSandboxRequest.lifecycleschema for the optionalpreStartandperiodichooks.OPEN_SANDBOX_LIFECYCLEenvironment variable for Kubernetes workloads so execd can consume it.This is the Server part of OSEP-0020 (#1542). It complements the execd implementation in #1587 and the API Spec/SDK changes in #1588. PATCH and other lifecycle hooks are intentionally out of scope.
Testing
Validated:
Breaking Changes
Checklist